refactor(elidable_lifetimes): harmonize suggestion-building logic with extra_unused_type_parameters
#15908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estions" This reverts commit 25881bf.
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
simplify-elidable_lifetimes
branch
from
081ac53 to
d666c68
Compare
samueltardieu
requested changes
Oct 21, 2025
rustbot
added
S-waiting-on-author
.. and add some docs to both of them
ada4a
force-pushed
the
simplify-elidable_lifetimes
branch
from
d666c68 to
17f1942
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
samueltardieu
approved these changes
Oct 22, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to come up with a clever algorithm (#15667), but it's even nicer to reuse logic that already exists elsewhere.
changelog: none
r? @samueltardieu as you reviewed the original PR